Feedback

[hendroucc]

Contracts

Mint Contract

create_asset:

• add Creator only function check.
• manager, reserve, freeze and clawback address are not required

asset_transfer:

• Asset ID verification with global state

asset_burn:

• Asset ID verification with global state

Holdings Contract

asset_optin:

• add Creator only function check.
• Asset ID verification with global state
• check if Asset has not been opted in before

sell_token:

• Asset ID verification with global state
• check if transfer amount is > 0
• Atomic transfer check, group size and type of transaction
• check if Transaction amount includes fees to cover the inner transaction.

Burn Contract

handle_creation:

• Save asset ID in global state

asset_optin:

• add Creator only function check.
• Asset ID verification with global state

Deployment Scripts

Main deployment

• save holdings app ID via checkpoint

Actions

Application Frontend

• Reference the appIDs and addresses easily without hardcoding using checkpoints . e.g.

  
  # bad
  const holdingsApp = configHolding.default.ssc["holdings_approval.py-holdings_clearstate.py"]["1662193106"].appID;

good

const holdingsApp = configHolding.default.metadata.holdingsAppID

### SendAssetForm.vue

- Do asset opt in transaction if the buyer hasn’t done so.
- Function is an atomic transfer consisting of payment and app call
- Display transaction ID if successful.
- Handle transaction errors if any and display warning alert

## Test Cases

### Success Flow

### Negative Tests

add these test cases as well:

- Double asset creation fails
- Asset creation fails when non-creator calls
- Asset transfer fails when supply is insufficient
- Asset burn fails when supply is insufficient
- Asset transfer fails when non-creator calls
- Asset burn fails when non-creator calls
- Selling token fails when supply < amount sold
- Selling tokens fails when transaction is not grouped
- Buying 0 token fails
- Buying tokens with insufficient algos
- Transfer token to non holding app fails
- Burn token to non burn app fails

[hendroucc]

Contracts

Holdings Contract

purchase:

• check if Payment amount includes fees to cover the inner transaction.

  Assert(Gtxn[0].amount() == (price * amount_of_tesla) + 1000)

Actions

SendAssetForm.vue

• add 1000 microalgos on amount of txn2 to cover inner txn fee

@28091999