search

28Smiles / jdbi-modules

Modular SQL and mapping for Jdbi
Apache License 2.0
2 stars 1 forks source link

fix: Prefer HashMap over ConcurrentHashMap #16

Closed dhardtke closed 5 years ago

dhardtke commented 5 years ago

Since the Map instance is not shared across modules or even multiple threads it does not make sense to use a ConcurrentHashMap here which has a larger memory footprint than HashMap

codecov[bot] commented 5 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     89.15%   89.15%           
  Complexity      106      106           
=========================================
  Files            16       16           
  Lines           295      295           
  Branches         17       17           
=========================================
  Hits            263      263           
  Misses           27       27           
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
src/main/java/jdbi_modules/Module.java 100% <100%> (ø) 5 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 883fe27...6f4e184. Read the comment docs.