search

28Smiles / jdbi-modules

Modular SQL and mapping for Jdbi
Apache License 2.0
2 stars 1 forks source link

Fix unnecessary space at the end #20

Closed dhardtke closed 5 years ago

dhardtke commented 5 years ago

I noticed that sometimes in queries that Jdbi-Modules generates there is an additional space at the end, e.g.,


SELECT "mod0knowlex_exercise".id AS "mod0id", "mod0knowlex_exercise".randomize_task_pools AS "mod0randomize_task_pools", knowlex_exercise.created, knowlex_exercise.updated, knowlex_exercise.disabled, knowlex_exercise.name, knowlex_exercise.description FROM (SELECT exercise.*, knowlex_exercise.randomize_task_pools FROM knowlex_exercise JOIN exercise ON exercise.id = knowlex_exercise.id WHERE (exercise.id = :m0) AND (disabled = :m1)) "mod0knowlex_exercise" ", rewritten:"SELECT "mod0knowlex_exercise".id AS "mod0id", "mod0knowlex_exercise".randomize_task_pools AS "mod0randomize_task_pools", knowlex_exercise.created, knowlex_exercise.updated, knowlex_exercise.disabled, knowlex_exercise.name, knowlex_exercise.description FROM (SELECT exercise.*, knowlex_exercise.randomize_task_pools FROM knowlex_exercise JOIN exercise ON exercise.id = knowlex_exercise.id WHERE (exercise.id = :m0) AND (disabled = :m1)) "mod0knowlex_exercise" ", parsed:"ParsedSql{sql='SELECT "mod0knowlex_exercise".id AS "mod0id", "mod0knowlex_exercise".randomize_task_pools AS "mod0randomize_task_pools", knowlex_exercise.created, knowlex_exercise.updated, knowlex_exercise.disabled, knowlex_exercise.name, knowlex_exercise.description FROM (SELECT exercise.*, knowlex_exercise.randomize_task_pools FROM knowlex_exercise JOIN exercise ON exercise.id = knowlex_exercise.id WHERE (exercise.id = ?) AND (disabled = ?)) "mod0knowlex_exercise" ```

This PR fixes that.
codecov[bot] commented 5 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.09%. The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #20      +/-   ##
===========================================
+ Coverage      90.5%   90.6%   +0.09%     
  Complexity      110     110              
===========================================
  Files            16      16              
  Lines           295     298       +3     
  Branches         17      16       -1     
===========================================
+ Hits            267     270       +3     
  Misses           23      23              
  Partials          5       5
Impacted Files Coverage Δ Complexity Δ
src/main/java/jdbi_modules/base/StructuredSql.java 95.65% <80%> (+0.65%) 6 <3> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa99e18...36bb2b8. Read the comment docs.