Closed syntaqx closed 5 years ago
If possible -- please enable the CircleCI setting for testing PRs so I can get a read on if the changes there worked. master
is the only branch that will perform a release
but the other step should be fully functional. You'll want to turn this button from off (the state my picture is in) to on:
If not, that's fine too. Just trying to help.
thanks @syntaqx will take at this changes, tonight!
I ran into an issue where environment variables used in the definition of the executor environment aren't expanded.... So I went through and replaced expanded IMAGE_NAME where it appeared. I image there's a better way, but it works for now.
executors:
buildpack:
environment:
IMAGE_NAME: $CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME
I've enabled "builds for pull requests from forks" and taken the *docker-login alias out of the build job, so I'd expect that part to run for PRs, now.
Big thanks for the contribution. Hoping to spend some more time with this soon π
I'm not surprised that you found an issue, I was sort of just winging all of the changes on almost no sleep - Glad that you got things merged in and I'll keep an eye on anything else I might be able to help on.
Let me know if I broke anything else π
Before I dump all this on you:
Changeset
/data
for consistency with the majority of containers This is also exposed as aVOLUME ["/data"]
for overwriting with custom images. Not all use cases will need the overlayfsblast-radius:latest
a second tag is pushed to the registry:docker push blast-radius:$TF_VERSION
- Version locking is extremely essential with TF Cloud given remove state files can't always be rewoundget
andinit
through overridable usage ofTF_CLI_ARGS_*
-- This is also used for Terraform 0.12 credentials and workspaces (an example is in thedocker-compose.yml
)requirements.txt
, allowing Docker to benefit from layer caching when no packages are changed.setup.py
as well as removal of legacy keys. I didn't replace them all, but I got sleepy and wanted to open this up.Should affect positive change for #24 #28 #33 #36 #43 #54 -- Not necessarily 100% fixes but at least normalizes the Docker runtime.
Anyways... π