28mm / blast-radius

Interactive visualizations of Terraform dependency graphs using d3.js
https://28mm.github.io/blast-radius-docs/
MIT License
2.04k stars 257 forks source link

Issue sweeping - Terraform 0.12.2, Windows, Docker & PLY #65

Closed syntaqx closed 5 years ago

syntaqx commented 5 years ago

Before I dump all this on you:

  1. Sorry for not opening an issue and making sure this was cool to drop
  2. REALLY sorry about the size of the changeset. It kind of snowballed into a bunch of things before I got everything working again.

Changeset

Should affect positive change for #24 #28 #33 #36 #43 #54 -- Not necessarily 100% fixes but at least normalizes the Docker runtime.

Anyways... πŸŽ‰

syntaqx commented 5 years ago

If possible -- please enable the CircleCI setting for testing PRs so I can get a read on if the changes there worked. master is the only branch that will perform a release but the other step should be fully functional. You'll want to turn this button from off (the state my picture is in) to on:

image

If not, that's fine too. Just trying to help.

28mm commented 5 years ago

thanks @syntaqx will take at this changes, tonight!

28mm commented 5 years ago

I ran into an issue where environment variables used in the definition of the executor environment aren't expanded.... So I went through and replaced expanded IMAGE_NAME where it appeared. I image there's a better way, but it works for now.

executors:
  buildpack:
    environment:
IMAGE_NAME: $CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME

I've enabled "builds for pull requests from forks" and taken the *docker-login alias out of the build job, so I'd expect that part to run for PRs, now.

Big thanks for the contribution. Hoping to spend some more time with this soon πŸ‘

syntaqx commented 5 years ago

I'm not surprised that you found an issue, I was sort of just winging all of the changes on almost no sleep - Glad that you got things merged in and I'll keep an eye on anything else I might be able to help on.

Let me know if I broke anything else πŸ˜†