28mm / blast-radius

Interactive visualizations of Terraform dependency graphs using d3.js
https://28mm.github.io/blast-radius-docs/
MIT License
2.04k stars 258 forks source link

Docker support #7

Closed 28mm closed 6 years ago

28mm commented 6 years ago

@brogersyh -- just merged your changes from #6 . Really wonderful stuff. I'm a faltering and infrequent user of docker, but managed to upload to the docker hub under 28mm/blast-radius, and will make this part of the release process.

Cutting an issue for discussion.

Anyway, would be glad to have your thoughts, and happy new years 🥂

bucrogers commented 6 years ago

Re fonts - changed to from alpine to ubuntu and this resolved it, at least on my simple example (now renders correction as for MacOS), I've submitted another PR - although it makes the image bigger, doesn't matter much at this stage.

Terraform init vs. get - will think about this more as i apply it to my project over the coming days

Thx for putting this together, I think it has a lot of potential, will let you know how it is working for my scenarios

br

bucrogers commented 6 years ago

I've noticed occasionally a request (when in --serve mode) doesn't render - another request immediately after does. When this occurs, there is only the HTTP GET command in the log, nothing after.

28mm commented 6 years ago

Haven't yet replicated the issue of failed requests that you describe. Looking to add some tests with curl and chromedriver, to hopefully uncover this sort of issue.