search

28msec / nolap-report-editor

Deprecated go to
https://github.com/28msec/cellstore
Apache License 2.0
3 stars 3 forks source link

Export import #183

Closed dknochen closed 9 years ago

dknochen commented 9 years ago

frontend part

dknochen commented 9 years ago

@wcandillon you can already take a look if you want.

the backend implementation is here : https://github.com/28msec/secxbrl.info/pull/492

this branch still needs an e2e test. Therefore, its still work in progress

wcandillon commented 9 years ago

@dknochen Yep that's the stuff. So fancy. I just miss the import from template part. And then I have some super minor comments, I just need to think about it a little more.

On the backend side, I asked a question which is unanswered and I also need to git it a little bit deeper before approving it.

dknochen commented 9 years ago

@wcandillon the template implementation is not part of this PR. Its a different feature and will be in a different PR. hope it makes sense.

wcandillon commented 9 years ago

@dknochen Looks good. Fancy stuff. Please remove the part where you can "rename the imported report". The rename feature is orthogonal. Other than that, it is good to merge.

wcandillon commented 9 years ago

Awesome