search

29988122 / Fate-Grand-Order_Lua

Fate Grand Order auto battle script - no root needed, for Android use only
MIT License
289 stars 95 forks source link

Issue selecting supports #106

Closed raspberrytealeaf closed 5 years ago

raspberrytealeaf commented 5 years ago

Hiya,

I'm using the waver face cards and holy night supper included from your files. It works the majority of the time, but sometimes I will get an error:

image image

I have no idea what triggers this, but I think it's related to scrolling down / swiping on the friends list. When there's a Waver w/Holy Night Supper at the 1st or 2nd slots, it seemingly has no issues selecting him.

Any suggestions on how to fix this?

ryuga93 commented 5 years ago

The error happens when the scrolling reached the end of the support list, causing the boundary to fall out of expected range.

You can reduce the value of Support_SwipesPerUpdate, maybe to 4 to fix it.

@potchy Maybe instead of throwing the error, how about catching it and toast it as notification and proceed to update the support list?

raspberrytealeaf commented 5 years ago

Ah, I see. I'll reduce the swaps. Thanks.

potchy commented 5 years ago

Just to confirm: the error appeared when the script found the right match in the 3rd support slot? I mean 3rd visible on screen, not total.

What's your screen resolution, by the way?

@ryuga93 I'll consider that, but first I want to confirm what's triggering it. In my experience, when the end of the support list is reached, the script continues to try scrolling a few more times and then clicks "update". I wonder what's different. A screenshot of the game after the error would help a lot!

ryuga93 commented 5 years ago

image It throws error when the second visible servant is matched regardless the CE. For the image above, I'm trying to get Ishtar with the 5 Start Gacha CE.

raspberrytealeaf commented 5 years ago

@potchy It seems to occur after it swipes down a few times and needs to refresh cause it doesn't find the servant + CE you want. I think what @ryuga93 said is on point. My screen res is whatever the default NOX resolution is.

TryBane commented 5 years ago

@raspberrytealeaf While working on a fix, it might be better to limit the number of swipes in the settings in the meantime to keep it from throwing that error.

potchy commented 5 years ago

I just pushed a fix for this issue. Please help check if it has indeed been solved before I close it. 😄

raspberrytealeaf commented 5 years ago

I've been running the updated script for a while w/more siwpes and so far I haven't encountered the same error. Thanks!