search

29988122 / Fate-Grand-Order_Lua

Fate Grand Order auto battle script - no root needed, for Android use only
MIT License
289 stars 95 forks source link

Feature/party selection #401

Closed forgehe closed 4 years ago

forgehe commented 4 years ago

367

I'd appreciate it if ppl test that it works on their devices as well. The tapping locations are quite close to each other, so I don't want any misclicks to occur. I'm mainly concerned about phones with notches, as I don't have a way to test that. Confirmed to work on Samsung S9.

forgehe commented 4 years ago

Just ran into an issue, where if the selected party was already in use, the start quest click wouldn't register for some reason. (Eg. AutoSkill uses Party 1, Party 1 is already the default. Start Quest Button doesn't register) (Eg2. AutoSkill uses Party1, Party 2 is the default. Start Quest Button registers the click)

Tested cases when this occurs:

  1. Party formation on Party1. Clicks on Party1.
  2. Party formation on Party1. 3 Clicks on Party2 (not fully consistent, but the more I tap on the same party, the more likely to happen. Switching to a new party by clicking twice on it does not cause this problem)

In addition to the Start Quest not working, I cannot click on the Master Equip, Line Up, Edit Party, Class Affinity Buttons. Auto Burning Settings and Help still work fine.

Ways found to resolve the issue:

  1. Clicking another party.
  2. Clicking the help dialogue.
  3. Dragging the Party left or right.
  4. Tapping on a CE or Servant

I think the easiest way to go around this issue is to switch to Party 1, and then back to the user-specified party (and selecting Party 2 if the user-specified party is party 1).

reconman commented 4 years ago

I didn't even know that you can click on the dots at the top!

Seems like a good solution, I'll test this soon.

reconman commented 4 years ago

@forgehe Can you check my corrections?

forgehe commented 4 years ago

Corrections and documentation looks good!

forgehe commented 4 years ago

Just had one occurance where it tapped to Party2, and 2nd tap to Party1 did not register. It may be a fluke, but I'm thinking it might occur more frequently on laggier devices.