search

29jitender / Spotlight

Spotlight is an Android library used to onboard users by showcasing specific features in the app.
Apache License 2.0
1.27k stars 163 forks source link

Fix dismiss issues #54

Closed tvkanters closed 5 years ago

tvkanters commented 7 years ago

These changes some some issues that I found while using a sequence. The main one involved just tapping the spotlight view multiple times. Because dismiss was called for each tap, the animation spazzed out and the onUserClicked callback was triggered multiple times, breaking the sequence badly.

Another issue could occur when focus was lost between views of a sequence. Since requestFocus() was only called before the view was visible, it didn't actually seem to do anything. By calling it right after the view is set visible, focus is actually granted, and the back button functions properly.

ShaiAlkoby commented 5 years ago

can you merge this? it fixes an annoying issue with the onbackpress