search

29jm / SnowflakeOS

"It is very special"
https://jmnl.xyz
MIT License
316 stars 18 forks source link

Better mouse cursor #13

Closed the-grue closed 3 years ago

the-grue commented 3 years ago

Created arrow shaped mouse cursor and made some changes to resolve streaking in the mouse rectangle along with a disappearing cursor issue I discovered.

Some minor optimizations to replace divisions with shifts were also added to the code.

the-grue commented 3 years ago

Thanks! I actually got out my graph paper and mapped it out.

One recommendation, in reference to your "bureaucratic" comment. This is your repo/project. If you have specific coding preferences or style that you would like us contrubitors to adhere to, that might make a good wiki page. Tabs vs. Spaces, where to put curly braces, etc. can vary from project to project. In fact, I believe wars have been fought over them.

I'll try to be mindful of these things going forward. Thanks for the tips!

29jm commented 3 years ago

Thank you for all the changes, that's perfect! I took the liberty of squashing the commits while merging, didn't want to do it via github as it's pretty unclear what it'll do, so it doesn't show as merged here... I'll try something else next time.

You're totally right about the need for contributing guidelines, this would remove a lot of uncertainty and after-the-fact requests, I really need to do that. The way things are right now I never know how much to ask from contributors, and they can't know what to do, it's a mess ^^