Currently, when an enlistment liaison views an enlistment from /manage/enlistments/xxx, the following information is fetched on page load:
discourse username
discourse email adderss
discourse IP address
other discourse users who've used the same IP address
vanilla username (if applicable)
other vanilla users who've used the same IP address (if applicable)
It involves 3-6 network requests every time the page loads, which is clearly a bit silly, and is the reason those pages are a bit slow.
We could speed it up dramatically by fetching that information once and saving it in the database. Perhaps we fetch it when the person enlists, and save it in the enlistment record?
The question then, is from an MP security perspective. For example, if a user enlists and then creates a new discourse account (with the same IP address), that new discourse account wouldn't show with this approach. Or if they enlist and then start using the forum with a new IP address, which is linked to other users, those linked users won't show. But maybe that's okay? Like, is that scenario realistic? Theoretically we could implement a refresh button, but then we'd expect liaisons to click that every time anyway, which kind of brings us back to where we are today.
Currently, when an enlistment liaison views an enlistment from
/manage/enlistments/xxx, the following information is fetched on page load:It involves 3-6 network requests every time the page loads, which is clearly a bit silly, and is the reason those pages are a bit slow.
We could speed it up dramatically by fetching that information once and saving it in the database. Perhaps we fetch it when the person enlists, and save it in the enlistment record?
The question then, is from an MP security perspective. For example, if a user enlists and then creates a new discourse account (with the same IP address), that new discourse account wouldn't show with this approach. Or if they enlist and then start using the forum with a new IP address, which is linked to other users, those linked users won't show. But maybe that's okay? Like, is that scenario realistic? Theoretically we could implement a refresh button, but then we'd expect liaisons to click that every time anyway, which kind of brings us back to where we are today.
Thoughts, @conrad29th @swomma ?