29th / personnel-v3

Personnel management system version 3
https://www.29th.org
2 stars 6 forks source link

Refactor graduation process #283

Closed wilson29thid closed 5 months ago

wilson29thid commented 5 months ago

Try to remove the Cadet and TrainingPlatoon models if they're not necessary, and make sure there are no n+1 queries. We've got great test coverage now so this should make it easier.

If we can remove the TrainingPlatoon model, the activeadmin resource can just use:

scope_to do
  Unit.training_platoons
end