search

29th / personnel-v3

Personnel management system version 3
https://www.29th.org
2 stars 6 forks source link

Fix order of squads in graduation unit dropdown #287

Closed wilson29thid closed 4 months ago

wilson29thid commented 5 months ago

Image

wilson29thid commented 4 months ago

On investigation, it appears it's annoyingly difficult to order these

 "DP3 HQ (1631/1/467) (3)",
 "DP3S1 (1631/1/467/1245) (1)",
 "DP3S2 (1631/1/467/1245) (2)",
 "DP3S3 (1631/1/467/1245) (3)",
 "DP3S4 (1631/1/467/1245) (4)",
 "DP1S1 (1631/1/467/468) (1)",
 "DP1S2 (1631/1/467/468) (2)",
 "DP1S3 (1631/1/467/468) (3)",
 "DP2S1 (1631/1/467/469) (1)",
 "DP2S2 (1631/1/467/469) (2)",
 "DP2S3 (1631/1/467/469) (3)",
 "DP2S4 (1631/1/467/469) (4)",

I'm currently ordering by ancestry, then by order, but it treats ancestry as a string and orders them as above, when it should be ordering by each units' ancestor's order, which is much more complex.

I think in order to implement this we'll need to do #290 and then use the flatten_arranged_nodes class method.

wilson29thid commented 4 months ago

um wait can't we just sort by abbr?