2Checkout / woocommerce

2Checkout WooCommerce Connector
MIT License
23 stars 13 forks source link

Some bugs to fix #1

Closed sagitaire123 closed 4 years ago

sagitaire123 commented 4 years ago

Hello,

First problem :

I'm using 2Checkout Inline and ConvertPlus, there's a problem when we try to complete a purchase for a pending order that we have on "My Account > My Orders", when we click on pay on woocommerce we are redirected to : https://website.com/checkout/order-pay/2948/?pay_for_order=true&key=wc_order_XXXXXXXX

From this page, it's not possible to make a payment, the popup to make the payment is not opened and we are redirected to a blank page.

Second Problem :

In case you're using this plugin, at WC checkout page if you select (ConvertPlus/Inline/2PayJS) and you change your mind and you want to select another Payment Method like PayPal for example, it will not work, the redirection to PayPal don't work after clicking on "Complete payment", some JS errors occur.

Thank you

sagitaire123 commented 4 years ago

@DAHcod For me for example, i don't have PayPal on 2Checkout so it ask client to put his credit card numbers directly, at the final step, and it's better like that for my case.

@Sonansh i think @craigchristenson didn't change the version of the plugin yet because it's only a release version, it was not committed yet until we make enough tests. For 3D secure, i have clients who are making payments through 2Checkout Inline and they didn't face any problem with 3D secure, i didn't get any complains about that. For the colors, @DAHcod didn't change anything, it's the default color of the first and second step, and the third step is green, that's normal. you need to understand that the box of 2Checkout Inline is not really implemented on the plugin, it's only a request sent to 2Checkout to display it on our website, so it's managed by 2Checkout and not the plugin. @craigchristenson can confirm if i'm right.

Sonansh commented 4 years ago

@sagitaire123 , When I downloaded the CSV report of recent failed orders, all of them said "unfinished" on the 3D secure column in that excel report. That's why I was concerned. However, when I myself did a test payment, 3D secure worked. 3Ds

For the color, yes it appears to be controlled by 2checkout and not the plugin. But I think there should be an option to control that color from 2checkout admin.

sagitaire123 commented 4 years ago

@craigchristenson i made tests of the last release, the problem of switching to other payment method is fixed on "My Account" page, but now the same problem is on "Checkout" page, the problem just changed pages lol

@Sonansh can you check also from your side.

DAHcod commented 4 years ago

@DAHcod For me for example, i don't have PayPal on 2Checkout so it ask client to put his credit card numbers directly, at the final step, and it's better like that for my case.

@Sonansh i think @craigchristenson didn't change the version of the plugin yet because it's only a release version, it was not committed yet until we make enough tests. For 3D secure, i have clients who are making payments through 2Checkout Inline and they didn't face any problem with 3D secure, i didn't get any complains about that. For the colors, @DAHcod didn't change anything, it's the default color of the first and second step, and the third step is green, that's normal. you need to understand that the box of 2Checkout Inline is not really implemented on the plugin, it's only a request sent to 2Checkout to display it on our website, so it's managed by 2Checkout and not the plugin. @craigchristenson can confirm if i'm right.

For this only when you click icon Cart on your 2Checkout inline you can see PayPal option. I want to the first step our customers can see 2 choice Credit card or PayPal and they will choose payment method first like the photo I attached before.

sagitaire123 commented 4 years ago

@DAHcod That's not an issue i think but it's a new feature, it must be an option on the plugin (to choose which page we want to see first), so you can make the proposal to 2Checkout, and maybe it will be done on the next version. For my case, i don't really need it, as i have only Credit Card.

Sonansh commented 4 years ago

@DAHcod I keep a dedicated option for Paypal active which comes default in woocommerce. That is probably the best solution for paypal. I use 2checkout only for credit cards. However it offers a paypal option too. That's just an extra good thing for me. But for Paypal I prefer a default option active.

So at checkout, I offer two separate payment options. 1) Paypal by woocommerce default 2) 2checkout (which also includes a paypal option)

@sagitaire123 I will check and update

DAHcod commented 4 years ago

@DAHcod That's not an issue i think but it's a new feature, it must be an option on the plugin (to choose which page we want to see first), so you can make the proposal to 2Checkout, and maybe it will be done on the next version. For my case, i don't really need it, as i have only Credit Card.

Really I think it has been already integrated. You can click on my circle as the attached photo.

E7C998FC-E52D-4406-9368-48D81FBBA202 .

sagitaire123 commented 4 years ago

@Sonansh @DAHcod @craigchristenson pushed a new version : https://github.com/2Checkout/woocommerce/tree/release it seems working good now, you can make tests from your side and confirm.

DAHcod commented 4 years ago

@craigchristenson Can you make my issue please? I want to it shows first start: Cart --> Billing --> Payment (See photo 1). This plugin now is showed Payment first (See photo 2). No any option Credit and PayPal for users to choose when it displays first. I want users can see first 2 option Credit and PayPal when popup displayed first like photo 1.

@sagitaire123, I tested and it seems working but it is better if it goes to first start Cart --> Billing --> Payment (See photo 1)

Photo 1

Photo 2

Sonansh commented 4 years ago

Hi @sagitaire123 and @craigchristenson

I have tested the plugin on the remaining issues. The gateways now successfully works from "My account" and re-works again on checkout page.

However, I realized that your old plugin has a smart functionality that is missing in this version.

Old plugin - https://docs.woocommerce.com/document/2checkout-inline-checkout/

Functionality misssing:

If the person does't want to procced to checkout after he has started the proccess maybe because he wants to edit items in his cart. The old plugin still restores the cart is the person went back from the checkout. But this plugin clears the cart.

I would appreciate if this functianlity is considered.

DAHcod commented 4 years ago

@craigchristenson Can you make my issue please? I want to it shows first start: Cart --> Billing --> Payment (See photo 1). This plugin now is showed Payment first (See photo 2). No any option Credit and PayPal for users to choose when it displays first. I want users can see first 2 option Credit and PayPal when popup displayed first like photo 1.

@sagitaire123, I tested and it seems working but it is better if it goes to first start Cart --> Billing --> Payment (See photo 1)

Photo 1

Photo 2

@craigchristenson Can you do my issue please?

craigchristenson commented 4 years ago

https://docs.woocommerce.com/document/2checkout-inline-checkout/

In my testing with the inline module, I can bring up inline, close it, go back to my cart to edit/add items and bring up inline again to pay for the current cart. It could be that you do not have the latest release or that I don't understand the feature request. I merged the release branch to master today. When you get a chance can you please confirm that you still have this issue on the current release?

craigchristenson commented 4 years ago

@craigchristenson Can you make my issue please? I want to it shows first start: Cart --> Billing --> Payment (See photo 1). This plugin now is showed Payment first (See photo 2). No any option Credit and PayPal for users to choose when it displays first. I want users can see first 2 option Credit and PayPal when popup displayed first like photo 1. @sagitaire123, I tested and it seems working but it is better if it goes to first start Cart --> Billing --> Payment (See photo 1) Photo 1 Photo 2

@craigchristenson Can you do my issue please?

This is happening because the plugin uses the 2Checkout Inline Auto Advance feature. https://knowledgecenter.2checkout.com/Documentation/07Commerce/InLine-Checkout-Guide/Turn-on-auto-advance-feature I will make sure that we make this configurable in a future release, in the meantime you can remove this line to get the behavior you want. https://github.com/2Checkout/woocommerce/blob/69fe92af8b498a6869a1eb7f00b6c9bfbdbd4f37/twocheckout-inline/assets/js/twocheckout_inline.js#L54

DAHcod commented 4 years ago

@craigchristenson Can you make my issue please? I want to it shows first start: Cart --> Billing --> Payment (See photo 1). This plugin now is showed Payment first (See photo 2). No any option Credit and PayPal for users to choose when it displays first. I want users can see first 2 option Credit and PayPal when popup displayed first like photo 1. @sagitaire123, I tested and it seems working but it is better if it goes to first start Cart --> Billing --> Payment (See photo 1) Photo 1 Photo 2

@craigchristenson Can you do my issue please?

This is happening because the plugin uses the 2Checkout Inline Auto Advance feature. https://knowledgecenter.2checkout.com/Documentation/07Commerce/InLine-Checkout-Guide/Turn-on-auto-advance-feature I will make sure that we make this configurable in a future release, in the meantime you can remove this line to get the behavior you want. https://github.com/2Checkout/woocommerce/blob/69fe92af8b498a6869a1eb7f00b6c9bfbdbd4f37/twocheckout-inline/assets/js/twocheckout_inline.js#L54

I have removed line 54 like you said but nothing change. Still same issue. Please do let me know more. Thank you.

craigchristenson commented 4 years ago

@craigchristenson Can you make my issue please? I want to it shows first start: Cart --> Billing --> Payment (See photo 1). This plugin now is showed Payment first (See photo 2). No any option Credit and PayPal for users to choose when it displays first. I want users can see first 2 option Credit and PayPal when popup displayed first like photo 1. @sagitaire123, I tested and it seems working but it is better if it goes to first start Cart --> Billing --> Payment (See photo 1) Photo 1 Photo 2

@craigchristenson Can you do my issue please?

This is happening because the plugin uses the 2Checkout Inline Auto Advance feature. https://knowledgecenter.2checkout.com/Documentation/07Commerce/InLine-Checkout-Guide/Turn-on-auto-advance-feature I will make sure that we make this configurable in a future release, in the meantime you can remove this line to get the behavior you want. https://github.com/2Checkout/woocommerce/blob/69fe92af8b498a6869a1eb7f00b6c9bfbdbd4f37/twocheckout-inline/assets/js/twocheckout_inline.js#L54

I have removed line 54 like you said but nothing change. Still same issue. Please do let me know more. Thank you.

Please try clearing your cache to insure that you are getting the updated JS file and please clear your cookies to remove the previous order session. TwoCoInlineCart.cart.setAutoAdvance(true); is the setting that skips the first 2 steps of inline checkout.

DAHcod commented 4 years ago

@craigchristenson Can you make my issue please? I want to it shows first start: Cart --> Billing --> Payment (See photo 1). This plugin now is showed Payment first (See photo 2). No any option Credit and PayPal for users to choose when it displays first. I want users can see first 2 option Credit and PayPal when popup displayed first like photo 1. @sagitaire123, I tested and it seems working but it is better if it goes to first start Cart --> Billing --> Payment (See photo 1) Photo 1 Photo 2

@craigchristenson Can you do my issue please?

This is happening because the plugin uses the 2Checkout Inline Auto Advance feature. https://knowledgecenter.2checkout.com/Documentation/07Commerce/InLine-Checkout-Guide/Turn-on-auto-advance-feature I will make sure that we make this configurable in a future release, in the meantime you can remove this line to get the behavior you want. https://github.com/2Checkout/woocommerce/blob/69fe92af8b498a6869a1eb7f00b6c9bfbdbd4f37/twocheckout-inline/assets/js/twocheckout_inline.js#L54

I have removed line 54 like you said but nothing change. Still same issue. Please do let me know more. Thank you.

Please try clearing your cache to insure that you are getting the updated JS file and please clear your cookies to remove the previous order session. TwoCoInlineCart.cart.setAutoAdvance(true); is the setting that skips the first 2 steps of inline checkout.

It works perfectly. Thank you so much.

DAHcod commented 4 years ago

Hi @craigchristenson, I have an issue. At step Pay for order I want users have to tick choose: "I have read and agree to the website terms and conditions" before they submit. Now my issue no any tick and users still submit. This issue need to fix.

See the attached file.

Thank you. Screenshot

Sonansh commented 4 years ago

Hey @DAHcod, I tested what you say but it's working on my end. I believe it is the basic woocommerce thing and not the 2checkout plugin thing. test

DAHcod commented 4 years ago

Hey @DAHcod, I tested what you say but it's working on my end. I believe it is the basic woocommerce thing and not the 2checkout plugin thing. test

Hi @Sonansh, Please note that this issue happens with "Pay for order" button not "Place Order" button. Please go to user's account --> orders --> Pay | View | Cancel. You choose "Pay" button and try it. You will have result like me.

DAHcod commented 3 years ago

Hi @craigchristenson, I have an issue. At step Pay for order I want users have to tick choose: "I have read and agree to the website terms and conditions" before they submit. Now my issue no any tick and users still submit. This issue need to fix.

See the attached file.

Thank you. Screenshot

@craigchristenson Do you have any update for this issue?