`summarize_range()` gains `na.rm` and defaults to removing `NA`s - Githubissues

2DegreesInvesting / tiltIndicator

Indicators for the TILT project

https://2degreesinvesting.github.io/tiltIndicator/

GNU General Public License v3.0

1 stars 1 forks source link

`summarize_range()` gains `na.rm` and defaults to removing `NA`s #743

Closed maurolepore closed 4 months ago

maurolepore commented 4 months ago

Relates to https://github.com/2DegreesInvesting/tiltIndicatorAfter/issues/188

devtools::load_all()
#> ℹ Loading tiltIndicator

data <- tibble::tibble(x = c(1, 2, 3, NA))

# Now
data |> summarize_range(x, na.rm = TRUE)
#> # A tibble: 1 × 2
#>     min   max
#>   <dbl> <dbl>
#> 1     1     3

# Bad
data |> summarize_range(x)
#> # A tibble: 1 × 2
#>     min   max
#>   <dbl> <dbl>
#> 1    NA    NA

TODO

[x] Link related issue/PR.
[x] Describe the goal of the PR. Avoid details that are clear in the diff.
[x] Mark the PR as draft.
[x] Include a unit test.
[x] Review your own PR in "Files changed".
[x] Ensure the PR branch is updated.
[x] Ensure the checks pass.
[x] Change the status from draft to ready.
[x] Polish the PR title and description.
[ ] Assign a reviewer.

EXCEPTIONS

[ ] Slide here any item that you intentionally choose to not do.