search

2DegreesInvesting / tiltIndicator

Indicators for the TILT project
https://2degreesinvesting.github.io/tiltIndicator/
GNU General Public License v3.0
1 stars 1 forks source link

Check why some `companies_id` have NA in `country` in tiltIndicatorBefore #744

Closed Tilmon closed 4 months ago

Tilmon commented 4 months ago

(This should be in tiltIndicatorBefore but I can't transfer it to that repo for some reason, so pls do it yourself)

Hi @kalashsinghal ,

Mauro found in this comment https://github.com/2DegreesInvesting/tiltOutput/issues/1#issuecomment-1991633387 that there are some companies_idwith NA in country. This shouldn't be the case, as in tiltData every companies_idhas a corresponding country.

Can you pls check where this originates from?

Thanks!

cc' @AnneSchoenauer @maurolepore

maurolepore commented 4 months ago

@Tilmon see https://github.com/2DegreesInvesting/tiltOutput/issues/1#issuecomment-1991814366

I think the important country column (with no NAs) is passed to tiltIndicatorAfter via the argument europages_companies -- not via the argument companies.

I'll assume my comment solves this issue (if anything what needs to be done is to remove the confusing country column from the companies dataset).