Closed kalashsinghal closed 3 months ago
@maurolepore I can see that there are some workflows which are failing in Github Actions . Do I need to make any change in other packages as well for making this change?
@maurolepore
ml02. In the original issue by @Tilmon I see he refers only to emissions_profile() but this PR seems to also affect emissions_profile_upstream().
Yes, it does also affect emission_profile_upstream()
, but we don't need this change now. We won't use upstream results right now. I.e., if implementing it for the emission_profile_upstream()
costs extra time, we should leave it out for now and change it at a later stage. For now, we only need results for the indicators that are not upstream.
Thanks @Tilmon
It's actually less work to do it for both than for one indicator alone.
Dear @maurolepore,
As per the new requirement, we have to change the benchmark from
tilt_sector
andinput_tilt_sector
totilt_subsector
andinput_tilt_subsector
respectively. Please review this change asap. Thanks!cc @Tilmon @AnneSchoenauer
TODO