2DegreesInvesting / tiltIndicatorAfter

Process indicator results so that they are closer to the user-facing outputs
https://2degreesinvesting.github.io/tiltIndicatorAfter/
GNU General Public License v3.0
0 stars 0 forks source link

Duplicates in Output Files #115

Open AnneSchoenauer opened 10 months ago

AnneSchoenauer commented 10 months ago

Dear @SKruthoff and @ysherstyuk,

Thanks a lot for your work on this! @Tilmon noticed the following in the emission profiles_company

Duplicates: running dplyr::distinct() on the datasets emission_profile_company.csv, emission_profile_product.csv, emission_profile_upstream_at_company_level.csv shows that all these 3 datasets have duplicates. Only tested for these 3. All datasets should be tested for duplications and duplications avoided. E.g. the companies_id "adolf-wurth-gmbh-co-kg_00000004971238-001" has all rows twice in the emission_profile_product.csv.

Could you double check if there is a quality check included that would avoid this? And do you know where the duplicates come from? Is this an issue in the code from GitHub or is there something happening on DataBricks that makes this mistake? If it is due to the code on GitHub we would need to investigate where this comes from.

Best Anne

Tilmon commented 9 months ago

@SKruthoff and @ysherstyuk do you already have an update on this issue? Or will you be able to work on it still this week? Thanks! cc' @AnneSchoenauer

SKruthoff commented 9 months ago

Hi,

yes I am working on it in the line of comparing the outputs. The duplicates seem to come from the column extra_rowid. Kalash right now is working on removing this column from the final output as he said that it should not be a part of the user facing output.

After this column is removed, I will rerun the package again and double check if the issue for the duplicates is solved.

Tilmon commented 9 months ago

Sounds good, thanks for the update!

Tilmon commented 2 months ago

@SKruthoff @ysherstyuk is this issue already resolved? If so, please close the ticket.