2DegreesInvesting / tiltToyData

Toy datasets for tilt
https://2degreesinvesting.github.io/tiltToyData/
GNU General Public License v3.0
0 stars 0 forks source link

Update Sector profile toy datasets #36

Closed kalashsinghal closed 8 months ago

kalashsinghal commented 8 months ago

@maurolepore I have replaced sector profile toy datasets with the new ones after merging this PR in tiltToyDataPrivate. The new toy datasets are fake enough to be used publicly.

I haven't applied any deprecation warnings of new datasets as the name of old and new datasets are same. Although, after coming from holidays if you feel that there should be any deprecation warning for any reason, then we can go back to an older commit which would have these deleted files and can add any deprecation warning you think is needed. I will work on this task after you think deprecation warning is needed. Thanks for your review!

Unfortunately, I have to merge this PR without your approval because, I and Linda need the toy datasets for our remaining tasks. However, please review this PR and create any issue you think is required. Thanks :)


TODO

EXCEPTIONS

kalashsinghal commented 8 months ago

@maurolepore One test didn't pass and the reason is tiltIndicatorAfter repo's checks are failing in this repo due to toy datasets change. I will update the tests in tiltIndicatorAfter to avoid such cases in the future. However, I will ask for your review after I update the tests.