2DegreesInvesting / tiltWebTool

https://bit.ly/tilt-app-info
https://2degreesinvesting.github.io/tiltWebTool/
GNU General Public License v3.0
1 stars 0 forks source link

Update welcome.yml #253

Closed Tilmon closed 3 months ago

Tilmon commented 3 months ago

Hi @kalashsinghal please review my PR to test the workflow @maurolepore was suggesting :)


The whole game:

maurolepore commented 3 months ago

For convenience I pasted the checklist at the tip and checked @Tilmon's action.

Tilman

@Tilmon, good on you for linking the related issue. What you missed there was a keyword so that GitHub closes the linked issue automatically. There are a few valid keywords but the only one you need to remember is "close". Also remember that if you start a line with * then GitHub automatically expands the issue number to show the title.

So this

* Close #252

Becomes this:

But this

# 252

Besomes this

252

Kalash

@kalashsinghal please continue and let me know your questions so I can respond before the end of this week. Note the 5' linked video (see checklist above) on how and why to test the app locally.

kalashsinghal commented 3 months ago

@maurolepore I tested the app locally and it works fine. I tested it both on product and company level as suggested by you in the 5 min video. Therefore, I will merge this PR.

image

kalashsinghal commented 3 months ago

@Tilmon @AnneSchoenauer Please validate the changes on staging so that I can create a new release.