2KAbhishek / co-author.nvim

Quickly add co-authors to commits 💻🪄
GNU General Public License v3.0
23 stars 2 forks source link

[BUG]: Error when selecting someone as co author #5

Closed kevinrobayna closed 6 months ago

kevinrobayna commented 6 months ago

Description of the bug

Unable to add people as co author

My config:

return {
  "2kabhishek/co-author.nvim",
  dependencies = {
    "stevearc/dressing.nvim",
    "nvim-telescope/telescope.nvim",
  },
  cmd = { "CoAuthor" },
}

Steps To Reproduce

:CoAuthor Select a person Error appears (see picture)

Additional Information

image

2KAbhishek commented 6 months ago

@kevinrobayna can you recreate this on a dummy repo and show me what your git commit message buffer looks like

The error probably looks like you are trying to insert at the last line, but I can't tell without the screenshot

kevinrobayna commented 6 months ago

@kevinrobayna can you recreate this on a dummy repo and show me what your git commit message buffer looks like

The error probably looks like you are trying to insert at the last line, but I can't tell without the screenshot

repository: https://github.com/kevinrobayna/dotfiles

I opened this nvim from lazygit

Screenshot 2024-05-01 at 13 49 08

Screenshot 2024-05-01 at 13 49 14

kevinrobayna commented 6 months ago

Just realised that if i do this after running git commit it does load a different UI and it does work 🤔

image

2KAbhishek commented 6 months ago

Yes, you are right, coauthor.nvim is supposed to be ran on the GIT_COMMIT_MSG buffer

if this resolves your issue, feel free to close it or lmk if you have something else

kevinrobayna commented 6 months ago

Yes, you are right, coauthor.nvim is supposed to be ran on the GIT_COMMIT_MSG buffer

if this resolves your issue, feel free to close it or lmk if you have something else

uhm 🤔 but the lazygit commit buffer is a GIT_COMMIT_MSG buffer

kevinrobayna commented 6 months ago

I found the fix for it will raise a pr for this now

kevinrobayna commented 6 months ago

Raised this PR for it: https://github.com/2KAbhishek/co-author.nvim/pull/6