2No2Name / hopperOptimizations

A mod that optimizes hoppers and their interactions with entities and inventories. It drastically reduces hopper lag without changing any behavior.
MIT License
64 stars 9 forks source link

[Bug] OptimizedInventories true, hoppers cannot push item into dropper #13

Closed aria1th closed 4 years ago

aria1th commented 4 years ago

2020-06-07_23 03 10 2020-06-07_23 03 08

hopper is directly facing into dropper but it does not pushes item into it. Hopper is not powered by anything.

2No2Name commented 4 years ago

Which version are you using? If you are not using the latest version, please update to the latest release https://github.com/2No2Name/hopperOptimizations/releases.

aria1th commented 4 years ago

I'm using the latest version. I found all options are true, not only optimizedinventories. It happens when hopper have consistent flow of in & out, when it tries to push item into dropper.

2No2Name commented 4 years ago

I cannot reproduce this by trying around. Can you provide a world download, schematic or structure block file, so I can debug using the setup you have?

aria1th commented 4 years ago

corruptcheck.zip

It's ilmango's fast acacia farm-based, with shulker loader. I placed spruce tree by 36tick interval, and afked for 4 hours, and by some point hopper failed to push items into dropper. I don't know it is the cause of the server crash, but server crashed due to [23:05:13] [Server Watchdog/FATAL]: A single server tick took 60.00 seconds (should be max 0.05), After the crash, server admin has disabled the mod, and hopper worked as it should be.

aria1th commented 4 years ago

I actually found that not only the tree farm, but also some kind of droppers repeatedly getting triggered and getting flows horizontally from dropper would make problem. All dropper/hopper did not had chunk border problem, and it's built on spawn chunk, always loaded by carpet fake player.

Mods used : fabric -Carpet 1.3.23, Carpet extra 1.3.18, Lithium, Phosphorus, Servux, hopperOptimizations ; MC java version 1.15.2

aria1th commented 4 years ago

I've successed reproducing this bug, with OptimizedEntityHopperInteraction true + OptimizedInventories true + OptimizedItemStackEmptyCheck true. It is world file.

2020-06-08_22 37 37

Middle hopper-dropper line is bugged, hopper is full of bonemeal but does not send any of it to dropper.

corruptcheck (1).zip

2No2Name commented 4 years ago

I still can't reproduce it, ran the farm for half an hour, and did not see any problems besides the shulker box unloader being too slow for the farm

aria1th commented 4 years ago

I thought that dropper was 'stable' blocked... maybe using tick warp command, I reproduced it with tick rate 300

Reloading the map/server actually solves the problem, but it still occurs. Actually shulker unloader is intended to be slow, farm runs less than 1/3 speed (36tick). I refilled bonemeal and summoned fake player, and set rate 300 and it occured again

aria1th commented 4 years ago

2020-06-08_22 35 30 2020-06-08_22 35 16 2020-06-08_22 35 29

Reloading world / restarting server solves the problem, but I don't know what's happening.

aria1th commented 4 years ago

Found that just having chest-hopper-dropper/dispenser with constant flow can jump into problem randomly, with very long period of time... I guess it's cache related problem. Not only in my computer, public server(fabric +carpet mod) had the problem. It is solved when server restarts, which means it do not save blocked state.

2No2Name commented 4 years ago

I made this contraption with an upwards facing dropper and the observer clock. I am tickwarping it and I am not encountering the problem. Do you have a minimal setup that reliably gets into the broken state after some time? 2020-06-08_21 51 42

aria1th commented 4 years ago

general_craft.zip I added tons of hoppers connected and used autocrafting module, and tick warped for a long time. I'd add schematic soon. I don't think it is reliable but seems like time does matters

2No2Name commented 4 years ago

There were many changes in the latest version, I believe this should be fixed now. Can you test it again, please?

aria1th commented 4 years ago

seems okay, Not found any stopped hopper

2No2Name commented 4 years ago

Thank you. If it occurs again, just create a new issue