search

2Retr0 / QuickStack

Quick stack to nearby chests!
MIT License
3 stars 4 forks source link

[bug] Most recent update doesnt show entity outlines upon quick stacking. #10

Open dmsw0303 opened 10 months ago

dmsw0303 commented 10 months ago

Fabric API: 0.91.0 Fabric Loader 0.15.3 Minecraft 1.20.1

I'd love to give you some more information, but despite the 250 mods in my modpack I dont really see anything that would be interfering with this. Mod works perfectly fine otherwise, and even highlights inventory slots upon stacking

Also dont have anything effecting the chest rendering outside of maybe Sodium, Indium, Flywheel/Create.

Really appreciate the update btw. I just found version 1.6.0 today before i went to bed, conked out and fell asleep before i could test it out and woke up to an update that presumably fixed a crash i would have experienced. so thank you very much, the alternative quick stack mod is kinda low quality so this was a welcome surprise

2Retr0 commented 10 months ago

I also came across this issue--Iris Shaders seems to be the culprit, specifically when using a non-SRGB color space (e.g., Display P3). The issue affects the glowing shader entirely it seems. Just to be sure, however, could you check if the glowing effect w/ non-SRGB color space issue persists even when QuickStack is unloaded?

And thank you for the kind words and your continued support, it means so much to me when I design and create these mods (despite the huge gap between updates haha).

2Retr0 commented 10 months ago

Related(?): IrisShaders/Iris#2156

dmsw0303 commented 10 months ago

So I'm not using iris actually, don't have it installed in my modpack. If you'd like a full list or a log I can definitely send it over. However, when quick stacking the logs for your mod looked 100% normal and wasnt throwing any errors, so I figured it wouldnt really be helpful.

I am using the forked version of Create that fixes compat with Sodium 0.5.0 and up. Ill try messing around with some things in the hopes of maybe being a little more helpful

dmsw0303 commented 10 months ago

Loool okay so I just disabled the forked version of create and this was the immediate result...

2024-01-09_09 33 34

dmsw0303 commented 10 months ago

This is a link to the mod, just so you know what I'm referring to https://modrinth.com/mod/create-fabric-sodium-fix However given the nature of the issue, I would not be surprised if a fix for this was outside of scope for the time being. Not having the outlines was not a big deal for me at all. I simply posted to let you know of the issue. Don't feel like you need to spend your time fixing this small edge case because I was already more than satisfied with the mod without it.

2Retr0 commented 10 months ago

Thanks for the clarification! I'll see if I can find some time to take a look at this--no promises however!