search

2amigos / yii2-chartjs-widget

ChartJs Widget For Yii2
https://2amigos.us
Other
109 stars 67 forks source link

Chart.js bower version #5

Closed fedemotta closed 9 years ago

fedemotta commented 9 years ago

Hi, I need to test some functionalities provided in the master branch of chart.js library. As I see in the yii2-chartjs-widget master branch, the composer file it is pointing to a specific release (1.0.2). I think this master branch should be using * and let the developer decide to specify a version (or not). If you make a release of this extension you could use the specified version (or not) but master should be using *. It is the development branch.

What do you think about this approach? Do you think it make sense?

tonydspaniard commented 9 years ago

@fedemotta thanks for suggestion. The reason why we decided to forced use of version is due to make sure we do not have BC issues with new releases of the plugin. If you use '*' you probably also have issues with minimum stability issues in composer.

fedemotta commented 9 years ago

If you use * and your project composer is in stable version it will use the 1.0.2 anyway. If your project is not stable yet it will use the master branch of that library. There is a @dev tag to use instead of * to avoid the minimum stability issues if you are in stable version and want a non stable library.

Also, correct me if I am wrong, with this approach you don't need to update your master branch if a new release of chart.js was made.

fedemotta commented 9 years ago

It was a very simple change. Feel free to merge or delete the PR #6

creocoder commented 9 years ago

@fedemotta Answered to PR.

fedemotta commented 9 years ago

@creocoder @tonydspaniard Please see my comments in the PR. Sorry to bother you!