search

2amigos / yii2-ckeditor-widget

CKEditor WYSIWYG widget for Yii2.
https://2amigos.us/open-source/ckeditor-widget
Other
172 stars 112 forks source link

updated ckeditor constraint #96

Closed schmunk42 closed 7 years ago

schmunk42 commented 7 years ago

I had issues installing the version in composer.json It should be a stable tag, are you currently referring to a branch?

Von meinem iPhone gesendet

Am 10.02.2017 um 08:25 schrieb Antonio Ramirez notifications@github.com:

@tonydspaniard commented on this pull request.

Does the change allows the modification of toolbars? Is it the full version (included all plugins)? I'll check it my friend! Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

schmunk42 commented 7 years ago

I checked the version: https://semver.mwl.be/#?package=ckeditor%2Fckeditor&version=dev-full%2Fstable&minimum-stability=dev

You need stability dev for your project to "see" `dev-full/stable" - contents of 4.6 and the former look OK to me, please double check it.

schmunk42 commented 7 years ago

That's the problem: https://github.com/ckeditor/ckeditor-releases/issues/41

tonydspaniard commented 7 years ago

@schmunk42 is this PR still relevant? Have you tried that if you make those changes the presets and all possible plugins still working?

Thanks!

schmunk42 commented 7 years ago

It is relevant, because currently this is broken, if you're not on dev.

As an example: https://github.com/dmstr/phd5-app/blob/a0a7b39a5cd97b669b32073c0af1c08229dd13ad/composer.phd5.json#L19 We have to use the constraint and require the package explicitly in our root composer.json - which defeats the purpose of dependency management.

Because of ckeditor/ckeditor-releases#41 - it seems like there's currently no 100% solution. I'd recommend to switch on a working composer/release tag and add a section to the docs how to use all plugins.

tonydspaniard commented 7 years ago

Because of ckeditor/ckeditor-releases#41 - it seems like there's currently no 100% solution. I'd recommend to switch on a working composer/release tag and add a section to the docs how to use all plugins.

Due to all these issues, thats why I considered in the past using assets folder within the library. CKEditor comes with far too many problems with their composer set. But community swapped. I am not sure we could get a proper composer release version with it. Let's work on it.

schmunk42 commented 7 years ago

Due to all these issues, thats why I considered in the past using assets folder within the library.

It's merely an issue with ckeditor, bundling the assets with the PHP package is heading into the wrong direction, since you have to update it manually all the time.

What's about not using the composer package, but rather npm?

tonydspaniard commented 7 years ago

Thank you master blaster @schmunk42 ! Versioning fixed! :)