2amigos / yii2-file-upload-widget

BlueImp File Upload Widget for Yii2
Other
252 stars 140 forks source link

Correct FileUploadAction.php class name #145

Closed wray-goenergies closed 5 years ago

wray-goenergies commented 6 years ago

Assuming there is not a reason for the class and file name to differ for this file I propose changing the class name AbstractUploadAction to match the file name FileUploadAction; which will also match the naming conventions of the other action files: FileListAction.php and FileDeleteAction.php.

tonydspaniard commented 6 years ago

@wray-goenergies thanks for your contribution. I'll check how that would affect BC and if it does, will merge and publish a major version update

cebe commented 5 years ago

@tonydspaniard the current state of the file does not allow autoloading it, so I do not see a reason to keep current name. The only way to properly use this code is to copy it to your application.

I am for merging this change.

tonydspaniard commented 5 years ago

@cebe thanks... you are correct.