search

2amigos / yii2-google-maps-library

Google Maps API library for Yii2
https://2amigos.us
BSD 3-Clause "New" or "Revised" License
106 stars 79 forks source link

Cast width and height attributes of Map to integer explicitly [PHP 7.2 fix] #116

Closed Infoto closed 6 years ago

Infoto commented 6 years ago

Casting them both to integer prevents: PHP Notice: A non well formed numeric value encountered in php Which happens when on PHP 7.2

I know this is a quick fix and not the best solution but if you do not like it, I will be happy to dig into it more a come up with a better solution.

Infoto commented 6 years ago

The problem is referenced in issue #114

tonydspaniard commented 6 years ago

Thanks @Infoto !