search

2amigos / yii2-grid-view-library

Highly enhanced GridView widget and grid components for Yii2
https://2amigos.us
Other
57 stars 16 forks source link

BooleanColumn is wrong #36

Open i-panov opened 5 years ago

i-panov commented 5 years ago

https://github.com/2amigos/yii2-grid-view-library/blob/9463fda4398715413c59dec9f7c04754b9fdb152/src/columns/BooleanColumn.php#L54

I think that there is an error in this line. What do you mean by the $treatEmptyAsFalse parameter? The function empty will not pass any empty value. Not 0, not empty string, not false, not null etc... If it comes to that, I would rewrite this line like this: if (!is_null($value)) {. But now it definitely works wrong!

tonydspaniard commented 5 years ago

Thanks @i-panov I'll have a look