search

2amigos / yii2-leaflet-extension

Yii 2 Extension library to display interactive maps with Leaflet .
http://yiiwheels.com
Other
30 stars 26 forks source link

$name on FeatureLayer #11

Closed SimonSoftware closed 9 years ago

SimonSoftware commented 9 years ago

Cannot add $name in LayerGroup (and on FeatoreGroup). And in encode() function 

 if (!empty($name)) {
            $js = "var $name = $js" . ($map !== null ? "" : ";");
}

is missed.

tonydspaniard commented 9 years ago

Will review when I have some free time... Thanks

SimonSoftware commented 9 years ago

OK, can i fork and modify? I do not know very well how to use github but I can try.

Paolo

Il 22/02/2015 13:28, Antonio Ramirez ha scritto:

Will review when I have some free time... Thanks

— Reply to this email directly or view it on GitHub https://github.com/2amigos/yii2-leaflet-extension/issues/11#issuecomment-75433241.

tonydspaniard commented 9 years ago

sure, thats what github is all about :+1:

tonydspaniard commented 9 years ago

@SimonSoftware This repository is now not a subtree split. If you are to propose a PR, do it on this repo.

tonydspaniard commented 9 years ago

This has been updated. Once all tests are done will update the version: https://github.com/2amigos/yii2-leaflet-extension/blob/master/src/layers/LayerGroup.php#L106