search

2amigos / yii2-leaflet-extension

Yii 2 Extension library to display interactive maps with Leaflet .
http://yiiwheels.com
Other
30 stars 26 forks source link

Two bugs in DivIcon->getOptions() #3

Closed sjaakp closed 10 years ago

sjaakp commented 10 years ago
  1. DivIcon->getOptions() calls all public get-methods (line 123). This of course includes getOptions() itself. The result is stack exhaustion. The fix might be to exclude the method getOptions explicitly.
  2. DivIcon->getOptions() collects alle the public properties in an array called $names (line 117), but this array is never used. Supposedly, the properties should be collected in $options.
tonydspaniard commented 10 years ago

@Sjaakp Thanks! Can you provide example code to check it properly? Please, @Sjaakp, if you think the code could improve somehow and maintain the simplicity and clean structure I would like to keep... do not hesitate to propose a pull-request. I would be very happy to review it.

tonydspaniard commented 10 years ago

I see what you meant... the simplest solution would be to make sure we do split the getOptions itself