search

2amigos / yii2-usuario

Highly customizable and extensible user management, authentication, and authorization Yii2 extension
https://github.com/2amigos/yii2-usuario
Other
294 stars 142 forks source link

Use version higher than 1.0.13 with yii2-bootstrap 2.1.x #134

Open kmergen opened 6 years ago

kmergen commented 6 years ago

Installing higher version than 1.0.13 with yii2-bootstrap 2.1.x (bootstrap 4) not possible, because yii2-selectize-widget need 2.0.x-dev.

image

tonydspaniard commented 6 years ago

@kmergen That version used on the official yii2 extension was in beta. As soon as they officially do the change, I'll modify all widgets to support that version.

In the meantime, any help is highly appreciated. I am very short in time nowadays.

Thanks for your feedback

kmergen commented 6 years ago

@tonydspaniard thanks. I will use yii2-usuario for my bootstrap 3 jobs and dektrium/yii2-user for bootstrap 4 at the moment.

olegbolden commented 6 years ago

Hi all First of all many thanks to yii2-usuario developers.

I'm using Bootstrap 4 vidgets from digitv. Upon install I disabled Bootstrap 3 in my 2.0.13.1 installation, because the above bundle comes with Bootstrap 4 support from twbs. I modified view files from yii2-usuario to match Bootstrap 4 styling and new widgets. Now it looks close to the original version. You can find view files in the attachment. Hope, it may be helpfull. views.zip

maxxer commented 6 years ago

I'd rather wait for yii2-bootstrap to release a definitive version of the BS4 extension, as right now there's still an active discussion ongoing on the official repo. They're still arguing if there should be a new repo or just a minor version upgrade (2.1).

I'd wait until that issue is resolved

tonydspaniard commented 6 years ago

@olegbolden I think I agree with @maxxer . We should support what Yii2 offers officially. Nevertheless, I am up to provide a specific branch where you could implement digitv if you wish @olegbolden. That could be a temporary solution for devs willing to use BS4.

tecnoterabyte commented 6 years ago

there is already an official repository yiisoft/yii2-bootstrap4

maxxer commented 6 years ago

I'm open to create a branch for yiisoft/yii2-bootstrap4, and adding it to the composer.json is pretty trivial. But I wonder how to proceed next.

I see it has no conflict with the current yii2-bootstrap, that means they can be installed together. Shall we keep both? How to understand if we're running on b3 or b4, via config param?

tecnoterabyte commented 6 years ago

I think the most advisable thing is to open a new branch just for bootstrap4 without having it mixed with bootstrap3.

maxxer commented 6 years ago

I was wondering how to support b4.

From the views posted by @olegbolden I see most of the changes are mainly on the namespaces. But there are some small cases where b3 specific styles has been used. For example the panel elements have been deprecated in favor of cards. This means we should make specific b4 views...

I don't know if mantaining two branches would be ideal. Other than this I think we could duplicate the view files. Not ideal as well, but these are the only options coming to my mind right now.

If anyone has a better solution please share. Thanks