search

2amigos / yii2-usuario

Highly customizable and extensible user management, authentication, and authorization Yii2 extension
https://github.com/2amigos/yii2-usuario
Other
296 stars 142 forks source link

./yii user/create Please fix following errors: #270

Open bscheshirwork opened 6 years ago

bscheshirwork commented 6 years ago

What steps will reproduce the problem?

install, migrate, try to create

./yii user/create test@test.test test

What is the expected result?

success or error description

What do you get instead?

empty error message "Please fix following errors:"

bscheshirwork commented 6 years ago

So.. This check is false https://github.com/2amigos/yii2-usuario/blob/c0afdd55c948f0aac1c8ef06e2136003485e9585/src/User/Command/CreateController.php#L36 but model user has no error. https://github.com/2amigos/yii2-usuario/blob/c0afdd55c948f0aac1c8ef06e2136003485e9585/src/User/Command/CreateController.php#L44 i.e. error from mailer not processed

bscheshirwork commented 6 years ago

Same error message for cath exeption: https://github.com/2amigos/yii2-usuario/blob/c0afdd55c948f0aac1c8ef06e2136003485e9585/src/User/Service/UserCreateService.php#L93-L98

tonydspaniard commented 6 years ago

@bscheshirwork that I think is due that the email has not being sent. And the following should be processed: https://github.com/2amigos/yii2-usuario/blob/c0afdd55c948f0aac1c8ef06e2136003485e9585/src/User/Service/UserCreateService.php#L85

Maybe we should remove that check and add the error no matter what.