search

2amigos / yii2-usuario

Highly customizable and extensible user management, authentication, and authorization Yii2 extension
https://github.com/2amigos/yii2-usuario
Other
294 stars 142 forks source link

🐛 fix(2FA): Two Factor Authentication - Filter - Blocks even when two… #519

Closed deadmantfa closed 9 months ago

deadmantfa commented 1 year ago

… factor authentication is enabled

🐛 fix(email): add error logging when email sending fails 🔒 chore(2FA): fix TwoFactorEmailValidator to pass user as an array The TwoFactorAuthenticationEnforceFilter was blocking users even when two factor authentication was enabled. The filter now checks if the user has two factor authentication enabled before blocking them. The MailService now logs an error when email sending fails. The TwoFactorEmailValidator now passes the user as an array to the TwoFactorEmailCodeGeneratorService.

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #513, #515
deadmantfa commented 1 year ago

I have made the requested changes. My apologies for not doing this sooner. @squio Can we merge these changes.

deadmantfa commented 11 months ago

Can this be merged please @squio

deadmantfa commented 9 months ago

@squio Can we please merge this pull request?

deadmantfa commented 9 months ago

@maxxer Thank you for merge

maxxer commented 9 months ago

Thank you for the PR! It was still missing strings update and your handle in the changelog. I hope you can contribute more in the future and add your name there. ciao

deadmantfa commented 9 months ago

Thank you for the PR! It was still missing strings update and your handle in the changelog. I hope you can contribute more in the future and add your name there. ciao

Sure I will make sure next time I do that. Will there be a version release based on this?

maxxer commented 9 months ago

I've no plans to release, but I might gather some other PR and do a 1.6.2 by the end of the year. Feel free to ping me if I don't.

deadmantfa commented 9 months ago

Sure @maxxer That would be great. Thank you for your help