Open AndreScara11 opened 7 months ago
@schmunk42 @eluhr since you use LDAP extension, do you mind having a look as well? thank you
In the last commit I adjusted the following things:
docs
folderdocs
folderphp-cs-fixer
First, thank you for contributing!
I am not a fan of how the Typeahead is being used here.
The typeahead original repo seems to be dead?
Also, the similar functionality here is used via 2amigos/yii2-selectize-widget. The latter is also abandoned, but using the already used dependency we will not be introducing a new "old/outdated" dependency here. In v2 branch bootstrap5 version select2 replaces yii2-selectize-widget.
We are generally dealing in v2 with the issue of how to get past old dependencies (bootstrap3), in this light adding something "old" on top of existing seems like going the wrong way.
I would suggest either use something alive and up to date, or go with using the already used selectize-widget here.
edit: or use kartik/select2 for this (replaces selectize-widget in v2). both select2 and selectize seem to have ajax quering options
Last changes:
ldapUid
to User model to handle the ldap users without the usernameDone, sorry for the misunderstanding.
Have you had a chance to review?
@schmunk42 @eluhr since you use LDAP extension, do you mind having a look as well? thank you
@maxxer since you asked for my opinion on this, here is my assessment. I find it somewhat critical to wire the LDAP so closely to the package. I think the whole thing would be better off in a separate package, which overwrites the required views and controller actions or works with the existing events at this point.
Implemented the possibility to autocomplete email and username from ldap when create a new user