search

2amigos / yiiwheels

Widget extension library for the YiiStrap extension
http://yiiwheels.2amigos.us
Other
133 stars 77 forks source link

WhVideoCarousel #109

Closed sganz closed 9 years ago

sganz commented 10 years ago

Just started trying the WhVideoCarousel working on a test site to see how it works and found that it displays of the 'indicator' (the dots) don't really work correctly, for example in the WhVideoCarousel demo on YiiWheels page it shows 6 indicators, but only 3 videos are in the player. Also selecting them works oddly. The html generated for the indicator looks odd, but I'm not sure what it's really supposed to be but I see six

  • tags for the indicators but I'm guessing only three should exist

    I'm not sure if this is an issue with the blueimp component but it looks like it's been updated a bit from the version that was in the YiiWheels download.

    My code was pulled from the YiiWheels site 03/25/2014 yiiwheels-1.0.3, but I just noticed an update to yiiwheels-1.0.4 in the time I pulled it down.

    Thanks

    Sandy

    • tonydspaniard commented 10 years ago

    YiiWheels was updated but it seems that it is a problem from the plugin itself

    sganz commented 10 years ago

    Thanks for the reply!

    I swapped out the latest version of blueimp gallery (2.14.0) and it seemed to function with the same problem, but otherwise seems to work OK. I think YiiWheels is currently deploying blueimp 2.7.1 (or close to it so it may be pretty old).

    I checked out the blueimp demo site and didn't see much mention of it but on their video demo they don't display the indicator in the HTML template. This is done in WhVideoCarousel's renderTemplate() function.

    I think the simple solution (for me anyways...) is to remove the code that generates the Html for the indicator, just like the author does.

    <ol class="indicator"></ol>

    And then the indicator is not visible, I will post a question to the blueimp fellow and see if he is aware or cares ;)

    Thanks again, just getting going with yii, yiistrap, yiiwheels, thanks for doing this work making the learning curve much lower and the productivity higher!

    Sandy

    tonydspaniard commented 10 years ago

    @sganz Thanks for your comments... If you have time and propose a PR will be happy to review.

    Thanks for the info anyway!

    tonydspaniard commented 9 years ago

    @sganz Library updated to work with BS3 starting on versions 2.+ Please, review the updated versions and update tickets for that.

    Thanks