search

2amigos / yiiwheels

Widget extension library for the YiiStrap extension
http://yiiwheels.2amigos.us
Other
133 stars 77 forks source link

Yiistrap version #111

Closed iurquiza closed 9 years ago

iurquiza commented 10 years ago

Is there a reason to still use the 2amigos version of yiistrap as a requirement? Could you update the composer.json file to use the crisu83 stable version? If not, could you please explain the reason why you want to keep the 2amigos version? Thanks.

tonydspaniard commented 10 years ago

@iurquiza the reason is no other than I do not have time at all and we are moving towards Yii2 and YiiWheels will change in nature when it come sto Yii2.

Nevertheless, if you have time to update the composer.json and make sure all widgets work correctly, feel free to do it, I will be happy to review.

iurquiza commented 10 years ago

Thanks @tonydspaniard. I will test the widgets and let you know.

tonydspaniard commented 10 years ago

related to #104

tonydspaniard commented 10 years ago

@iurquiza any updates? Thanks!

iurquiza commented 10 years ago

Hi Antonio,

I have not had a chance to test the widgets. I have been experimenting with the built-in Bootstrap features in Yii 2.0. I will begin working on a project using yiinitializr, so I will do some testing there.

Thanks!

nkovacs commented 10 years ago

I've replaced the yiistrap in yiiwheel-docs with crisu83's version and tried all the widgets, I only found one bug compared to your version, but that's in yiistrap: https://github.com/crisu83/yiistrap/issues/190

There are some other bugs, like using $.browser in jquery 1.9.

tonydspaniard commented 10 years ago

@nkovacs so you think we can make the change?

nkovacs commented 10 years ago

Yeah, aside from that url bug everything else worked the same.

tonydspaniard commented 9 years ago

Yiistrap version has been updated on 2amigos/yiistrap latest. I am fixing all issues related to Bootstrap 2+, once all done will mark that version. This issue therefore is now being closed.

Nevertheless, I am also working on Bootstrap 3+. Will be ready this weekend.