search

2amigos / yiiwheels

Widget extension library for the YiiStrap extension
http://yiiwheels.2amigos.us
Other
133 stars 77 forks source link

Setting 'arrows' option failing. #112

Closed kudzuu closed 9 years ago

kudzuu commented 10 years ago

Hi. If i will set 'arrows'=>false it does not take effect, because you are applying array_filter for $options so all false values will be removed.

tonydspaniard commented 10 years ago

Arrows from where @kudzuu ? I need to see some code, do not know for what you are pointing the issue.

kudzuu commented 10 years ago

Sorry. On line 331 (widgets/rangeslider/WhRangeSlider.php) there is $options array for js plugin configuration. There is no setting for arrows display configuration. This setting let you set whetever to show or not image arrows.

tonydspaniard commented 9 years ago

@kudzuu shouldn't $options allow you to do that?

kudzuu commented 9 years ago

What's the point then to have:

/* * @var bool lets you remove scrolling arrows on both sides of the slider. Defaults to true. / public $arrows = true;

tonydspaniard commented 9 years ago

@kudzuu I had to recall the code... I remember that I created that class differently, thinking that by providing the attributes would be easier for everyone to understand this widget. The options are built afterwards: https://github.com/2amigos/yiiwheels/blob/master/widgets/rangeslider/WhRangeSlider.php#L329

To tell you the truth, this is not the way I do widgets now when using external plugins. I really would love to update this library with new standards but I doubt it wouldn't break BC.

I think I have time to update the entire YiiWheels library to new version on next weeks.

kudzuu commented 9 years ago

There is very small fix. I will try to show you.

On Mon, Aug 25, 2014 at 9:51 PM, Antonio Ramirez notifications@github.com wrote:

@kudzuu https://github.com/kudzuu I had to recall the code... I remember that I created that class differently, thinking that by providing the attributes would be easier for everyone to understand this widget. The options are built afterwards: https://github.com/2amigos/yiiwheels/blob/master/widgets/rangeslider/WhRangeSlider.php#L329

To tell you the truth, this is not the way I do widgets now when using external plugins. I really would love to update this library with new standards but I doubt it wouldn't break BC.

I think I have time to update the entire YiiWheels library to new version on next weeks.

— Reply to this email directly or view it on GitHub https://github.com/2amigos/yiiwheels/issues/112#issuecomment-53273872.

Skype: kudzua.k.a.unclere

tonydspaniard commented 9 years ago

@kudzuu Updated the whole library for Bootstrap 3. Please, check new versions.