2amigos / yiiwheels

Widget extension library for the YiiStrap extension
http://yiiwheels.2amigos.us
Other
133 stars 77 forks source link

Multiple issues with TbTabs #52

Closed rlmckenney closed 10 years ago

rlmckenney commented 10 years ago

I know that this is a Yiistrap widget, but since YiiWheels is running its own fork, I am posting this here.

Testing with simple example:

<?php $this->widget('bootstrap.widgets.TbTabs', array(
    'tabs' => array(
        array('label' => 'Billing Address',  'content' => '...', 'active' => true),
        array('label' => 'Shipping Address', 'content' => '...'),
       ),
)); ?>

Results in a Fatal error on call to TbHtml::tabbable It is defined as a protected function and should be public.

If I change TbHtml::tabbable to be a public function, then the CHtml::tag call fails with:

htmlspecialchars() expects parameter 1 to be string, array given

From the stack trace:

CHtml::tag("li", array("itemOptions" => array(), "class" => "active"), "<a data-toggle="tab" tabindex="-1" href="#tab_1">Billing Address...", true)

I am running Yiistrap 1.0.1 and Wheels 1.0.3

tonydspaniard commented 10 years ago

Will have a look at it. Thanks @rlmckenney

tonydspaniard commented 10 years ago

@rlmckenney you need to upgrade your Yiistrap version. That issue was corrected with latest.