search

2bc4 / streamlink-ttvlol

Streamlink Twitch plugin modified to work with the TTV.LOL API
BSD 2-Clause "Simplified" License
158 stars 6 forks source link

additional information #3

Closed Sokoloft closed 1 year ago

Sokoloft commented 1 year ago

Added the should you block ads bit. As well as further expanded on the luminous-ttv explanation. Due to the first issue post. Minor changed to the readme.

Sokoloft commented 1 year ago

There could be even more explanation about luminous. Saying that the server should be running before and during the user watching a stream. 🤷

However, it seems you can close luminous once you have launched a stream. I'd assume the end user could figure it out though. Idk

Sokoloft commented 1 year ago

Hopefully that should clear things up. Ready to merge. Lmk if anything should change.

Sokoloft commented 1 year ago

As well as consider changing the repository name to streamlink-adblock. I think that makes more sense 🤷 If at all possible enable the discussions tab too.

2bc4 commented 1 year ago

Thanks for the PR as always, looks good and I agree with the video as well.

As well as consider changing the repository name to streamlink-adblock

The -ttvlol refers to the ttvlol API, and the patch only supports that right now. I'm not sure if that will ever change in the future so as of right now I think it's OK.

If at all possible enable the discussions tab too.

Done.