search

2bc4 / streamlink-ttvlol

Streamlink Twitch plugin modified to work with the TTV.LOL API
BSD 2-Clause "Simplified" License
188 stars 6 forks source link

Save volume level on Re-execution of Streamlink #47

Closed PsycloneTM closed 1 year ago

PsycloneTM commented 1 year ago

It's really annoying changing the volume back down. But I don't want the volume to be set down by default only on that instants of watching stream.

Sokoloft commented 1 year ago

It's really annoying changing the volume back down. But I don't want the volume to be set down by default only on that instants of watching stream.

What do you mean? I use it on windows with VLC. I don't have this issue. What player are you using? Please leave more information in the future.

PsycloneTM commented 1 year ago

It's really annoying changing the volume back down. But I don't want the volume to be set down by default only on that instants of watching stream.

What do you mean? I use it on windows with VLC. I don't have this issue. What player are you using? Please leave more information in the future.

Im using mpv on windows

Sokoloft commented 1 year ago

Im using mpv on windows

As a temporary solution you could edit MPV's config file. Adjusting the default volume to a level you wouldn't have to turn up. I use MPV on my Linux systems and I don't have this issue. So it could be something with your overall configuration. You could also try VLC on windows.

@2bc4 Would be able to troubleshoot more so. You could also fork this and add the functionality you're wanting yourself. However I think this is a config issue on your end. Maybe you're using a different player input? Use standard input if so and see if it differs.

Good luck.

2bc4 commented 1 year ago

Unfortunately this isn't realistically possible from Streamlink. Streamlink doesn't know what the player volume is, and there isn't a common API to query it.

mpv doesn't save the volume but there's a few mpv plugins that can do that for you. See https://github.com/mpv-player/mpv/issues/1913.

I use MPV on my Linux systems and I don't have this issue.

Likely because pulseaudio/pipewire is restoring the last volume for mpv.

PsycloneTM commented 1 year ago

Unfortunately this isn't realistically possible from Streamlink. Streamlink doesn't know what the player volume is, and there isn't a common API to query it.

mpv doesn't save the volume but there's a few mpv plugins that can do that for you. See mpv-player/mpv#1913.

I use MPV on my Linux systems and I don't have this issue.

Likely because pulseaudio/pipewire is restoring the last volume for mpv.

ok thanks and I prefer mpv for more customizability