check build into source control

2createStudio / postcss-sprites

Generate sprites from stylesheets.

MIT License

413 stars 50 forks source link

check build into source control #52

Closed ianstarz closed 8 years ago

ianstarz commented 8 years ago

fixes #51

removed lib/ from .gitignore
removed src/ from .npmignore
ran npm run build

This would be helpful for contributors so that they can fork, and try their forks out in their application before they open a PR, or use their forks in their application while awaiting a PR merge into upstream.

vvasilev- commented 8 years ago

You are right about that the source should be published to NPM but I don't see the reason to keep lib/ folder under version control. The contributors will run the build and test the modified version of the plugin.

ianstarz commented 8 years ago

@vvasilev- the problem is when I have a fix for an issue that I want to use in my project, I can't point my project to my fork while I wait for my PR to be accepted to this repository. Maybe there's a better way of handling this aside from checking lib into source control?

vvasilev- commented 8 years ago

You can use npm link to create a temporary alias to the fork and when your PR is accepted and published you can remove the alias.

ianstarz commented 8 years ago

that works if i'm the only one working on it, but my use case is working with a team and shipping production code via a build server. linking solution doesn't work well for that

ianstarz commented 8 years ago

after thinking it over, checking dist into source control would probably be annoying, maybe something like this could be a good solution? https://github.com/exogen/postinstall-build