search

2d-inc / Flare-Flutter

Load and get full control of your Rive files in a Flutter project using this library.
https://rive.app/
MIT License
2.55k stars 469 forks source link

FlareActor's timer remains active after FlareActor is disposed #189

Closed ravenblackx closed 4 years ago

ravenblackx commented 4 years ago

In our unit tests, an active timer remaining at the end of the test leads to a test failure.

If a widget with an active FlareActor is present in a unit test, the test fails due to a timer still being active at the end, unless the animation controller is allowed to complete. If completing the animation triggers another animation, this means we have to remove the widget, pump until it's gone, then one more pump(durationOfAnimationOrMore) to allow the timer to complete.

The timer should be canceled when the widget is disposed.

ravenblackx commented 4 years ago

/cc @luigi-rosso

ravenblackx commented 4 years ago

It looks like this has been silently fixed at some point.