2d-inc / Flare-Flutter

Load and get full control of your Rive files in a Flutter project using this library.
https://rive.app/
MIT License
2.55k stars 469 forks source link

3.0.0 antialiasing no longer working #301

Closed nt4f04uNd closed 2 years ago

nt4f04uNd commented 3 years ago

you can use this app as reproducible https://github.com/nt4f04uNd/flare_blink_bug

(open in new window to clearly see there's no antialiasing)

2.0.6 3.0.0
2 0 6 3 0 0
flutter doctor -v ``` [✓] Flutter (Channel master, 2.1.0-13.0.pre.386, on Microsoft Windows [Version 10.0.19041.867], locale ru-RU) • Flutter version 2.1.0-13.0.pre.386 at c:\dev\src\flutter • Framework revision 66af44c9fe (54 minutes ago), 2021-04-01 10:22:37 -0700 • Engine revision 9651d11fe8 • Dart version 2.13.0 (build 2.13.0-190.0.dev) [✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2) • Android SDK at C:\Users\danya\AppData\Local\Android\sdk • Platform android-30, build-tools 30.0.2 • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01) • All Android licenses accepted. [✓] Chrome - develop for the web • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe [✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7) • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community • Visual Studio Community 2019 version 16.7.30621.155 • Windows 10 SDK version 10.0.19041.0 [✓] Android Studio (version 4.0) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin version 50.0.1 • Dart plugin version 193.7547 • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01) [✓] IntelliJ IDEA Community Edition (version 2020.3) • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.3.3 • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart [✓] VS Code (version 1.55.0) • VS Code at C:\Users\danya\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.21.0 [✓] Connected device (3 available) • Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.19041.867] • Chrome (web) • chrome • web-javascript • Google Chrome 89.0.4389.90 • Edge (web) • edge • web-javascript • Microsoft Edge 89.0.774.63 • No issues found! ```
umberto-sonnino commented 3 years ago

What device are you repro'ing this on? I tried running the example on an iPad Mini, which had problems with this in the past, and it's rendering the shape with antialiasing correctly.

nt4f04uNd commented 3 years ago

android 9 redmi note 5 and android 11 emulator

umberto-sonnino commented 3 years ago

I've ran your file on the latest flutter master (Flutter version 2.2.0-11.0.pre.247) on an Android 11 emulator, and this is a zoomed in screenshot of the pause state:

Are you still seeing the issue?

nt4f04uNd commented 3 years ago

Yes, both on device and emulator

flutter doctor -v ``` [✓] Flutter (Channel master, 2.2.0-11.0.pre.274, on Microsoft Windows [Version 10.0.19041.928], locale ru-RU) • Flutter version 2.2.0-11.0.pre.274 at c:\dev\src\flutter • Upstream repository git@github.com:nt4f04und/flutter.git • Framework revision d1f73a1065 (18 hours ago), 2021-04-24 00:44:02 -0400 • Engine revision eba9efd1c3 • Dart version 2.14.0 (build 2.14.0-37.0.dev) [✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2) • Android SDK at C:\Users\danya\AppData\Local\Android\sdk • Platform android-30, build-tools 30.0.2 • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01) • All Android licenses accepted. [✓] Chrome - develop for the web • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe [✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7) • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community • Visual Studio Community 2019 version 16.7.30621.155 • Windows 10 SDK version 10.0.19041.0 [✓] Android Studio (version 4.1.0) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01) [✓] IntelliJ IDEA Community Edition (version 2020.3) • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.3.3 • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart [✓] VS Code (version 1.55.2) • VS Code at C:\Users\danya\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.21.0 [✓] Connected device (4 available) • Redmi Note 5 (mobile) • 40c9f14 • android-arm64 • Android 9 (API 28) • Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.19041.928] • Chrome (web) • chrome • web-javascript • Google Chrome 90.0.4430.85 • Edge (web) • edge • web-javascript • Microsoft Edge 89.0.774.77 • No issues found! ```
gnudles commented 3 years ago

Hi, for me it happens on linux device

gnudles commented 3 years ago

I think the problem comes from the following line: https://github.com/2d-inc/Flare-Flutter/blob/d3cc19d8827f9ddd074766271b651a8197ee8fea/flare_flutter/lib/flare.dart#L205

Henrik-glt commented 3 years ago

Any progress? Flare/Rive 1 animations look hideous using 3.0.0 or later. This is very unfortunate since 2.0.6 and earlier does not support null safety.

Henrik-glt commented 3 years ago

I've crated a PR. As @gnudles said, _antialias in FlutterActorDrawable, row 206, should default to true. Then enabling and disabling antialias works fine.

davidgalarza commented 2 years ago

Any update?? I'm facing the same trouble

mattsolle commented 2 years ago

Would love for this to be merged in.

tsinis commented 2 years ago

You can use PR's branch as git dependency until it's merged...

luigi-rosso commented 2 years ago

Sorry for the delay here. Looking into this today.

luigi-rosso commented 2 years ago

Version 3.0.2 fixes the issue. Thanks for the patience!