search

2d-inc / Flare-Flutter

Load and get full control of your Rive files in a Flutter project using this library.
https://rive.app/
MIT License
2.55k stars 469 forks source link

Make compatible with new RenderObject.dispose API #309

Closed dnfield closed 1 year ago

dnfield commented 3 years ago

After https://github.com/flutter/flutter/commit/c1fe2bd1e0fef2d9f54d51c59f58cb32c33a0726, RenderObject.dispose expects overrides to call super.

The framework now calls this method automatically at the right times, so the manual calls can be removed.

dnfield commented 3 years ago

This should probbly get a version constraint added to pubspec.yaml, but the changes haven't been published to flutter dev yet - they will be soon.

luigi-rosso commented 3 years ago

Is the change backwards compatible or do we need to wait for this to land in stable?

dnfield commented 3 years ago

This is not backwards compatible. Would you be open to publishing it with a version constraint? The version it first appears in is 2.3.0-24.0.pre

dnfield commented 2 years ago

(this is now the API used on stable)

dnfield commented 1 year ago

This doesn't seem to be something you intend to accept at this point - going to close this to get it out of my pull request view on GitHub. Feel free to merge if you so desire.