search

2d-inc / Flare-Flutter

Load and get full control of your Rive files in a Flutter project using this library.
https://rive.app/
MIT License
2.55k stars 469 forks source link

deprecate mat2d.sign - folks should use double.sign instead #33

Open kevmoo opened 5 years ago

kevmoo commented 5 years ago

https://github.com/2d-inc/Flare-Flutter/blob/307ee213ed458acba00808c6c9a7144337e29043/flare_dart/lib/math/mat2d.dart#L6-L8

https://api.dartlang.org/stable/2.1.0/dart-core/double/sign.html

luigi-rosso commented 5 years ago

Nice, I hadn't seen this was a property. Much cleaner. Thanks!

kevmoo commented 5 years ago

I've done similar before. "Oh, we have that..."

luigi-rosso commented 5 years ago

It's always nice when you do figure it out though, "oh that's smart, and of course I should've seen that..." :D

I referenced the wrong issue (too many issue trackers): https://github.com/2d-inc/Flare-Flutter/commit/7d646bf51865f237668b5bc60af32f02aff9b6ea

kevmoo commented 5 years ago

Careful! That's a breaking change, right? Deprecate? Changelog?

(I do this for a living)

On Fri, Jan 18, 2019, 17:40 Luigi Rosso <notifications@github.com wrote:

It's always nice when you do figure it out though, "oh that's smart, and of course I should've seen that..." :D

I referenced the wrong issue (too many issue trackers): 7d646bf https://github.com/2d-inc/Flare-Flutter/commit/7d646bf51865f237668b5bc60af32f02aff9b6ea

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/2d-inc/Flare-Flutter/issues/33#issuecomment-455737647, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCiv49Zt6pdiDxwliccrKKVhTcqzvdks5vEneegaJpZM4aI5CM .

luigi-rosso commented 5 years ago

It shouldn't be, but it could be if someone really went out of there way to use that function :) It was intended to be used internally (this was one of the first dart things I wrote). It was one of the first libs I wrote in dart, so yes it shouldn't have been exposed

kevmoo commented 5 years ago

dartdoc will keep you honest :-)

https://pub.dartlang.org/documentation/flare_dart/latest/math_mat2d/math_mat2d-library.html

On Fri, Jan 18, 2019 at 6:18 PM Luigi Rosso notifications@github.com wrote:

It shouldn't be, but it could be if someone really went out of there way to use that function :) It was intended to be used internally (this was one of the first dart things I wrote). It was one of the first libs I wrote in dart, so yes it shouldn't have been exposed

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/2d-inc/Flare-Flutter/issues/33#issuecomment-455740920, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCigz3LpasGqCSLG4f8-efJk_HCTrJks5vEoBhgaJpZM4aI5CM .

luigi-rosso commented 5 years ago

Oh that’s great, more new things :) thanks