Closed Killklli closed 4 days ago
current status: ✅
Overall Coverage
Lines Covered Coverage Threshold Status 22650 13346 59% 0% 🟢 New Files
No new covered files...
Modified Files
File Coverage Status conftest.py 29% 🟢 randomizer/Fill.py 65% 🟢 randomizer/ItemPool.py 68% 🟢 randomizer/Logic.py 83% 🟢 randomizer/Patching/Lib.py 42% 🟢 TOTAL 57% 🟢 updated for commit:
91cf3a1
by action🐍
This pull request includes several changes to the
randomizer
module to improve performance and simplify logic checks. The most important changes include the introduction of caching for frequently called functions, the addition of a new helper function for location skipping logic, and various refactorings to streamline the codebase.Performance improvements:
randomizer/Fill.py
: Added@lru_cache
decorator toGetExitLevelExit
,GetLobbyOfRegion
, andGetLevelExitTransition
functions to cache their results and improve performance. [1] [2]randomizer/Logic.py
: Added@lru_cache
decorator to frequently called functions and theCounter
class for efficient item counting. [1] [2]Code simplification and refactoring:
randomizer/Fill.py
: Introducedshould_skip_location
function to encapsulate the logic for determining whether a location should be skipped, reducing code duplication and improving readability.randomizer/Fill.py
: Refactored theGetAccessibleLocations
function to use slicing instead ofcopy()
for list duplication and streamlined various logic checks. [1] [2]Bug fixes and minor improvements:
randomizer/ItemPool.py
: Removed unused importIsItemSelected
to clean up the codebase.randomizer/Logic.py
: Fixed variable assignments in theReset
method to ensure proper initialization of progression variables.