search

2e2a / l-rex

Linguistic Rating Experiments
GNU General Public License v3.0
3 stars 1 forks source link

explicitly specify that condition names cannot include certain characters [wiki] #130

Closed dgj2702 closed 2 years ago

dgj2702 commented 4 years ago

Suggestion:

Condition labels can be any string of characters and/or numbers (e.g., "a", "b", "c" / "cond1", "cond2", "cond3" etc.); no other characters (e.g., full stops, etc.) are permitted.

2e2a commented 4 years ago

Not sure where this restriction comes from and why. Will take a look.

gvarab commented 4 years ago

@dgj2702 We could not reproduce a problem with special characters in the condition label – do you by any chance remember which character caused a problem? (As for the Wiki text, the examples were not intended to imply that only letters/numbers are allowed, so if other characters don't work, it's a bug).

dgj2702 commented 4 years ago

I had a full stop in my condition names. I will try now to reproduce the error.

dgj2702 commented 4 years ago

I was able to reproduce the problem, and you are correct, it does not appear to be related to the full stop, but the length of the label. For example, the label 'xxxx.xxx' gives me the error: "Line {}: unexpected format", but the label 'xxxx.xx' works without issue.

I must not have done a test with a minimal pair, instead changing the label enough that it worked. Hope that helps.

gvarab commented 4 years ago

Ah, thanks a lot! The limit for condition labels is currently 8 characters and it's a bug that this is not checked/indicated when uploading a CSV file. We will try to fix this and I'll re-consider the limit (and include it in the wiki).

dgj2702 commented 4 years ago

I see. I think informing users is needed, especially in the error message. Is there a reason to limit it to 8 characters?

gvarab commented 2 years ago

Character limit for the condition string has been increased to 16, and it is now stated in the help text of the form field as well as in the wiki.