search

2e2a / l-rex

Linguistic Rating Experiments
GNU General Public License v3.0
3 stars 1 forks source link

summary function: options switched [bug] #154

Closed dgj2702 closed 3 years ago

dgj2702 commented 4 years ago

When using the summary function for the results, the options are switched: the participant option shows me a summary by item, and the items option shows me a summary by participant.

gvarab commented 4 years ago

Ah, I think I have been mistaken about the word "aggregate": I thought "aggregated by X" means that we average over all data for category X rather than splitting it by X.

So I think it's not just these two option that are switched: we should also change "aggregated by: participant + item" to "aggregated by: none" (or, more precisely, "aggregated by: condition"; and the others would be "by condition+item", "by condition+participant". Thanks!

dgj2702 commented 4 years ago

Perhaps wording it slightly differently, e.g., "summarize by: participant" etc., would be easier to parse. Additionally, it would follow the "group_by" function in the tidyr package for r,

gvarab commented 4 years ago

Good idea, I'll change it to "summarize by".

gvarab commented 3 years ago

Fixed in 53819a7174e5e4fd0b8b0cc3f89bccb4933c46d5 (I kept the term 'aggregate', but fixed the conceptual error).