Closed Carlgo11 closed 4 years ago
Looks great, just a few items I suggest below.
Add a placeholder to add screenshots between these lines(or at the bottom).
Screenshots if no documentation link available
Add the Email 2FA
Email [ ]
Replace the word haven't with hasn't.
I have checked that the site hasn't
been suggested before - [ ]
Add the link for clarification stated in EXCLUSION.md.
as stated in the [Exclusions](https://github.com/2factorauth/twofactorauth/blob/master/EXCLUSION.md)
does not contain or promote pornographic, discriminatory or unlawful content - [ ] I suggest to change the text to
Link to documentation on how to configure 2FA on the site
(instead of enable
), because in some cases (banking) 2FA is mandatory, but the user may choose different methods.
The exception text and icon can probably be left out of the issue template (or make it optional?). If you happen to plan a PR template as well, they should be included there.
The site or service as stated ...
I would rather put it the other way around:
The site or service does not contain or promote pornographic, discriminatory or unlawful content as stated in the Exclusions - [ ]
@phallobst changed 😃
Should you also create a link for RFC-6238 since it is included?
Should there possibly be a link to the wiki Categories page to give examples, or clear definition of the different forms of 2FA?
Based on the WebAuthn documentation, it is authenticated using either hardware or software authenticator's. Should this not be included? If it is included you should lowercase the "N" at the end of WebAuthn to correctly match how it is used.
Should the line I have checked that the site hasn't been suggested before
include Issues or Pull Requests to indicate where to look.
If so, the line could be changed to I have searched the [Issues](https://github.com/2factorauth/twofactorauth/issues?utf8=✓&q=) and [Pull Requests](https://github.com/2factorauth/twofactorauth/pulls?utf8=✓&q=) to confirm the site hasn't been suggested before
It still says
The site or service as stated in the does not contain...
That is some residue from before, I guess.
It would probably be a good idea to add a template for requesting new sites. Any ideas on how it should be structured? Here's a draft of what I've come up with.
Closes #2318