search

2factorauth / twofactorauth

List of sites with two factor auth support which includes SMS, email, phone calls, hardware, and software.
https://2fa.directory
Other
3.36k stars 1.77k forks source link

Replace CircleCI with CF Worker #8090

Closed Carlgo11 closed 3 weeks ago

Carlgo11 commented 3 weeks ago

Over the weekend, I rewrote the tests run by CircleCI in JavaScript for Cloudflare Workers. As GitHub doesn't allow secrets to be used for workflows deployed by pull requests, a middleman such as CircleCI or Cloudflare needs to be used.

This PR adds a new workflow to this repository, which sends a GET request to the Cloudflare Worker upon PR changes. The Worker then fetches the modified files for the PR and runs tests using the file data.

Currently, the script validates the SimilarWeb rank and Facebook page handles. I had to drop the Twitter handle check because Elon made username searches a premium API feature :roll_eyes:

PR Validator code: 2factorauth/pr-validator

hkamran80 commented 3 weeks ago

I had to drop the Twitter handle check because Elon made username searches a premium API feature 🙄

Of course he did.

Does the ::error ... response show up in the files view?

Carlgo11 commented 3 weeks ago

Does the ::error ... response show up in the files view?

I haven't tested it, but it should show up in the files view as cURL just sends the response to /dev/stdout, and GitHub then interprets that.

hkamran80 commented 3 weeks ago

Looks good to me!